<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - op_get_by_id_with_this should use inline caching"
href="https://bugs.webkit.org/show_bug.cgi?id=162124#c52">Comment # 52</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - op_get_by_id_with_this should use inline caching"
href="https://bugs.webkit.org/show_bug.cgi?id=162124">bug 162124</a>
from <span class="vcard"><a class="email" href="mailto:ticaiolima@gmail.com" title="Caio Lima <ticaiolima@gmail.com>"> <span class="fn">Caio Lima</span></a>
</span></b>
<pre>View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=296872&action=review">https://bugs.webkit.org/attachment.cgi?id=296872&action=review</a>
<span class="quote">>> Source/JavaScriptCore/bytecode/PolymorphicAccess.cpp:971
>> + GPRReg baseForCustomGetGPR = baseGPR != thisGPR ? thisGPR : baseForGetGPR;
>
> Is this corrects? Have you tested it?</span >
I didn't create a test for that, however I think it is necessary. I'm going to double check that.
<span class="quote">>> Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:264
>> + if (spillMode == DontSpill) {
>
> This should always be a constant for this function. Please remove and make it just baked into the code.</span >
ok</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>