[Webkit-unassigned] [Bug 159398] [test262] Fixing mapped arguments object property test case

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=159398

Saam Barati <sbarati at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #297500|review?                     |review+
              Flags|                            |

--- Comment #84 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 297500
  --> https://bugs.webkit.org/attachment.cgi?id=297500
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297500&action=review

Nice. r=me with comments addressed.

> Source/JavaScriptCore/ChangeLog:29
> +        to store wich arguments[i] descriptor was changed from its default

Typo: wich => which

> Source/JavaScriptCore/runtime/GenericArgumentsInlines.h:70
> +    bool result = Base::getOwnPropertySlot(thisObject, exec, ident, slot);

Is this just to get the attributes?

> Source/JavaScriptCore/runtime/GenericArgumentsInlines.h:234
> +            if (thisObject->isMappedArgument(optionalIndex.value())) {

Nit: you can just use index since it's defined above.

> Source/JavaScriptCore/runtime/GenericArgumentsInlines.h.orig:1
> +/*

Oops. Please remove file.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161220/f85757fb/attachment.html>