<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [test262] Fixing mapped arguments object property test case"
href="https://bugs.webkit.org/show_bug.cgi?id=159398">bug 159398</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #297500 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [test262] Fixing mapped arguments object property test case"
href="https://bugs.webkit.org/show_bug.cgi?id=159398#c84">Comment # 84</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [test262] Fixing mapped arguments object property test case"
href="https://bugs.webkit.org/show_bug.cgi?id=159398">bug 159398</a>
from <span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=297500&action=diff" name="attach_297500" title="Patch">attachment 297500</a> <a href="attachment.cgi?id=297500&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=297500&action=review">https://bugs.webkit.org/attachment.cgi?id=297500&action=review</a>
Nice. r=me with comments addressed.
<span class="quote">> Source/JavaScriptCore/ChangeLog:29
> + to store wich arguments[i] descriptor was changed from its default</span >
Typo: wich => which
<span class="quote">> Source/JavaScriptCore/runtime/GenericArgumentsInlines.h:70
> + bool result = Base::getOwnPropertySlot(thisObject, exec, ident, slot);</span >
Is this just to get the attributes?
<span class="quote">> Source/JavaScriptCore/runtime/GenericArgumentsInlines.h:234
> + if (thisObject->isMappedArgument(optionalIndex.value())) {</span >
Nit: you can just use index since it's defined above.
<span class="quote">> Source/JavaScriptCore/runtime/GenericArgumentsInlines.h.orig:1
> +/*</span >
Oops. Please remove file.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>