[Webkit-unassigned] [Bug 164303] [GTK] BadDamage X Window System error in WebKit::AcceleratedBackingStoreX11::update when called from WebPageProxy::exitAcceleratedCompositingMode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=164303

Carlos Alberto Lopez Perez <clopez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |clopez at igalia.com

--- Comment #16 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
(In reply to comment #13)
> (In reply to comment #12)
> > Comment on attachment 295406 [details]
> > Patch
> > 
> > I'd like Zan to look at this.
> > 
> > Questions:
> > 
> >  (a) Isn't this equivalent to trapping the entire function, now? Both calls
> > to X11 APIs are within the scope of one trapper or another, we could just
> > put the trapper at the top so we only need one instead of two.
> 
> Not exactly the same, first one only happens if we already have a surface
> and second one if there's a pixmap and drawing area. We could just move it,
> though, but I prefer to make more expliit what we are protecting.
> 

Look at bug 164303

I think we should set the trapper for the whole function.

I would say more: I *really* would like that we trap all X error for the whole UIProcess and we just print them on stdout instead of crashing.


I really hate when things crash. I rather prefer to be on the wrong side by protecting things more than needed than be on the wrong side by crashing on corner cases that were not detected when this was implemented.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161216/8493dd29/attachment.html>