<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:clopez@igalia.com" title="Carlos Alberto Lopez Perez <clopez@igalia.com>"> <span class="fn">Carlos Alberto Lopez Perez</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [GTK] BadDamage X Window System error in WebKit::AcceleratedBackingStoreX11::update when called from WebPageProxy::exitAcceleratedCompositingMode"
href="https://bugs.webkit.org/show_bug.cgi?id=164303">bug 164303</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>clopez@igalia.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [GTK] BadDamage X Window System error in WebKit::AcceleratedBackingStoreX11::update when called from WebPageProxy::exitAcceleratedCompositingMode"
href="https://bugs.webkit.org/show_bug.cgi?id=164303#c16">Comment # 16</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [GTK] BadDamage X Window System error in WebKit::AcceleratedBackingStoreX11::update when called from WebPageProxy::exitAcceleratedCompositingMode"
href="https://bugs.webkit.org/show_bug.cgi?id=164303">bug 164303</a>
from <span class="vcard"><a class="email" href="mailto:clopez@igalia.com" title="Carlos Alberto Lopez Perez <clopez@igalia.com>"> <span class="fn">Carlos Alberto Lopez Perez</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=164303#c13">comment #13</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=164303#c12">comment #12</a>)
> > Comment on <span class=""><a href="attachment.cgi?id=295406&action=diff" name="attach_295406" title="Patch">attachment 295406</a> <a href="attachment.cgi?id=295406&action=edit" title="Patch">[details]</a></span>
> > Patch
> >
> > I'd like Zan to look at this.
> >
> > Questions:
> >
> > (a) Isn't this equivalent to trapping the entire function, now? Both calls
> > to X11 APIs are within the scope of one trapper or another, we could just
> > put the trapper at the top so we only need one instead of two.
>
> Not exactly the same, first one only happens if we already have a surface
> and second one if there's a pixmap and drawing area. We could just move it,
> though, but I prefer to make more expliit what we are protecting.
> </span >
Look at <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [GTK] BadDamage X Window System error in WebKit::AcceleratedBackingStoreX11::update when called from WebPageProxy::exitAcceleratedCompositingMode"
href="show_bug.cgi?id=164303">bug 164303</a>
I think we should set the trapper for the whole function.
I would say more: I *really* would like that we trap all X error for the whole UIProcess and we just print them on stdout instead of crashing.
I really hate when things crash. I rather prefer to be on the wrong side by protecting things more than needed than be on the wrong side by crashing on corner cases that were not detected when this was implemented.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>