[Webkit-unassigned] [Bug 165917] Fix memory leak in malformed test

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=165917

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #297256|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 297256
  --> https://bugs.webkit.org/attachment.cgi?id=297256
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297256&action=review

> LayoutTests/ChangeLog:10
> +        but we need to look into fixing this code-side.

You should file a bug about this. Also, maybe "in WebKitTestRunner" or something instead of "code-side"; JS counts as code no matter how you feel about the language :)

> LayoutTests/http/tests/quicklook/resources/tap-at-point-and-notify-done.js:6
> +function tapAtPointAndNotifyDoneGuarded(x, y)

Because it calls notifyDone(), it's *never* OK to do this twice, so I think you should just guard the other one instead. (I know you're trying to limit impact, but I almost think we would probably rather find out about other tests that would be broken by this change now rather than leave them silently doing stupid things).

> LayoutTests/http/tests/quicklook/resources/tap-at-point-and-notify-done.js:8
> +	if ( typeof tapAtPointAndNotifyDoneGuarded.guard == 'undefined' ) {

no spaces inside the parens

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161216/6e1b69b5/attachment-0001.html>