<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix memory leak in malformed test"
href="https://bugs.webkit.org/show_bug.cgi?id=165917">bug 165917</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #297256 Flags</td>
<td>review?, commit-queue?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix memory leak in malformed test"
href="https://bugs.webkit.org/show_bug.cgi?id=165917#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Fix memory leak in malformed test"
href="https://bugs.webkit.org/show_bug.cgi?id=165917">bug 165917</a>
from <span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=297256&action=diff" name="attach_297256" title="Patch">attachment 297256</a> <a href="attachment.cgi?id=297256&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=297256&action=review">https://bugs.webkit.org/attachment.cgi?id=297256&action=review</a>
<span class="quote">> LayoutTests/ChangeLog:10
> + but we need to look into fixing this code-side.</span >
You should file a bug about this. Also, maybe "in WebKitTestRunner" or something instead of "code-side"; JS counts as code no matter how you feel about the language :)
<span class="quote">> LayoutTests/http/tests/quicklook/resources/tap-at-point-and-notify-done.js:6
> +function tapAtPointAndNotifyDoneGuarded(x, y)</span >
Because it calls notifyDone(), it's *never* OK to do this twice, so I think you should just guard the other one instead. (I know you're trying to limit impact, but I almost think we would probably rather find out about other tests that would be broken by this change now rather than leave them silently doing stupid things).
<span class="quote">> LayoutTests/http/tests/quicklook/resources/tap-at-point-and-notify-done.js:8
> + if ( typeof tapAtPointAndNotifyDoneGuarded.guard == 'undefined' ) {</span >
no spaces inside the parens</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>