[Webkit-unassigned] [Bug 165793] [GStreamer] use FastMalloc-based GstAllocator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=165793

--- Comment #7 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
(In reply to comment #3)
> >> Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:161
> >> +        fprintf(stderr, "initializeGStreamer(): using FastMalloc allocator %p\n", allocator);
> > 
> > I would GST_INFO this, though it would require to add a debug category for this.
> 
> It's a debugging leftover, can be removed.

I think it is useful information to see in a GStreamer log.

Which brings another question to me: if we change the default allocator, we would be affecting other GStreamer multimedia playback outside WebKit. I'm beginning to wonder about the consequences of this.

> >> Source/WebCore/platform/graphics/gstreamer/GstAllocatorFastMalloc.cpp:36
> >> +    auto* mem = reinterpret_cast<GstMemoryFastMalloc*>(fastAlignedMalloc(alignment + 1, headerSize + allocationSize));
> > 
> > I prefer typed things when they are non-trivial, which IMHO is  the case.
> 
> This is typed like anything else, but it removes the duplicated information.

I know it is typed and I still prefer to see the explicit types at the code.


(In reply to comment #4)
> > Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:162
> > +        gst_allocator_set_default(allocator);
> 
> This could be moved before gst_init(), maybe? Seems to work (tm).

I wouldn't do it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161213/ef68e946/attachment.html>