<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] use FastMalloc-based GstAllocator"
href="https://bugs.webkit.org/show_bug.cgi?id=165793#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] use FastMalloc-based GstAllocator"
href="https://bugs.webkit.org/show_bug.cgi?id=165793">bug 165793</a>
from <span class="vcard"><a class="email" href="mailto:calvaris@igalia.com" title="Xabier RodrÃguez Calvar <calvaris@igalia.com>"> <span class="fn">Xabier RodrÃguez Calvar</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=165793#c3">comment #3</a>)
<span class="quote">> >> Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:161
> >> + fprintf(stderr, "initializeGStreamer(): using FastMalloc allocator %p\n", allocator);
> >
> > I would GST_INFO this, though it would require to add a debug category for this.
>
> It's a debugging leftover, can be removed.</span >
I think it is useful information to see in a GStreamer log.
Which brings another question to me: if we change the default allocator, we would be affecting other GStreamer multimedia playback outside WebKit. I'm beginning to wonder about the consequences of this.
<span class="quote">> >> Source/WebCore/platform/graphics/gstreamer/GstAllocatorFastMalloc.cpp:36
> >> + auto* mem = reinterpret_cast<GstMemoryFastMalloc*>(fastAlignedMalloc(alignment + 1, headerSize + allocationSize));
> >
> > I prefer typed things when they are non-trivial, which IMHO is the case.
>
> This is typed like anything else, but it removes the duplicated information.</span >
I know it is typed and I still prefer to see the explicit types at the code.
(In reply to <a href="show_bug.cgi?id=165793#c4">comment #4</a>)
<span class="quote">> > Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp:162
> > + gst_allocator_set_default(allocator);
>
> This could be moved before gst_init(), maybe? Seems to work (tm).</span >
I wouldn't do it.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>