[Webkit-unassigned] [Bug 165681] Web Inspector: Console could be made useful for very simple await expressions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=165681

--- Comment #5 from Brian Burg <bburg at apple.com> ---
Comment on attachment 296882
  --> https://bugs.webkit.org/attachment.cgi?id=296882
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=296882&action=review

The code changes look good, but I agree that stringifying the result is going to be confusing and we should try to avoid it somehow.

> LayoutTests/inspector/controller/runtime-controller.html:23
> +function causeExceptionImmediately() {

Nit: throwExceptionImmediately

> LayoutTests/inspector/controller/runtime-controller.html:76
> +        description: "Test evaluating a simple await expression wraps it into an async function and eventually resolves the value.",

Grammaro.

> Source/WebInspectorUI/UserInterface/Controllers/RuntimeManager.js:181
> +            esprimaSyntaxTree = esprima.parse("(async function(){" + originalExpression + "})");

Nit: template literal

> Source/WebInspectorUI/UserInterface/Controllers/RuntimeManager.js:206
> +            && statement.expression.type === "AwaitExpression") {

Unusual deviation from style guide, but it does make this more readable. Hmm. Up to you.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161212/5a5dee3d/attachment-0001.html>