<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Console could be made useful for very simple await expressions"
href="https://bugs.webkit.org/show_bug.cgi?id=165681#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Console could be made useful for very simple await expressions"
href="https://bugs.webkit.org/show_bug.cgi?id=165681">bug 165681</a>
from <span class="vcard"><a class="email" href="mailto:bburg@apple.com" title="Brian Burg <bburg@apple.com>"> <span class="fn">Brian Burg</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=296882&action=diff" name="attach_296882" title="[PATCH] Proposed Fix">attachment 296882</a> <a href="attachment.cgi?id=296882&action=edit" title="[PATCH] Proposed Fix">[details]</a></span>
[PATCH] Proposed Fix
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=296882&action=review">https://bugs.webkit.org/attachment.cgi?id=296882&action=review</a>
The code changes look good, but I agree that stringifying the result is going to be confusing and we should try to avoid it somehow.
<span class="quote">> LayoutTests/inspector/controller/runtime-controller.html:23
> +function causeExceptionImmediately() {</span >
Nit: throwExceptionImmediately
<span class="quote">> LayoutTests/inspector/controller/runtime-controller.html:76
> + description: "Test evaluating a simple await expression wraps it into an async function and eventually resolves the value.",</span >
Grammaro.
<span class="quote">> Source/WebInspectorUI/UserInterface/Controllers/RuntimeManager.js:181
> + esprimaSyntaxTree = esprima.parse("(async function(){" + originalExpression + "})");</span >
Nit: template literal
<span class="quote">> Source/WebInspectorUI/UserInterface/Controllers/RuntimeManager.js:206
> + && statement.expression.type === "AwaitExpression") {</span >
Unusual deviation from style guide, but it does make this more readable. Hmm. Up to you.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>