[Webkit-unassigned] [Bug 165173] run-benchmark should have a switch to avoid killing browser process unconditionally

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=165173

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rniwa at webkit.org

--- Comment #1 from Ryosuke Niwa <rniwa at webkit.org> ---
(In reply to comment #0)
> After r209090 <http://trac.webkit.org/changeset/209090> run-benchmark in
> Linux doesn't execute a "killall $browser" when it is asked to run the
> benchmarks with browser $browser. It instead keeps track of the browser PID
> it executed and only kill this PID.
> 
> This is a desired behaviour when the user is testing on the machine. However
> for a performance bot running tests automatically it isn't.
> 
> After discussing this in bug 164792 it seems we can add a command line
> switch to avoid issuing the killall, so users that want to avoid this
> behaviour of the script can just activate the switch. And at the same time
> we can keep as default behaviour killing all process with name $browser.

Alternatively, we can add an option like --kill-all to mean kill all existing browser instances to be used on bots.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161205/da776a44/attachment.html>