<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - run-benchmark should have a switch to avoid killing browser process unconditionally"
href="https://bugs.webkit.org/show_bug.cgi?id=165173">bug 165173</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>rniwa@webkit.org
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - run-benchmark should have a switch to avoid killing browser process unconditionally"
href="https://bugs.webkit.org/show_bug.cgi?id=165173#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - run-benchmark should have a switch to avoid killing browser process unconditionally"
href="https://bugs.webkit.org/show_bug.cgi?id=165173">bug 165173</a>
from <span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=165173#c0">comment #0</a>)
<span class="quote">> After r209090 <<a href="http://trac.webkit.org/changeset/209090">http://trac.webkit.org/changeset/209090</a>> run-benchmark in
> Linux doesn't execute a "killall $browser" when it is asked to run the
> benchmarks with browser $browser. It instead keeps track of the browser PID
> it executed and only kill this PID.
>
> This is a desired behaviour when the user is testing on the machine. However
> for a performance bot running tests automatically it isn't.
>
> After discussing this in <a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - [Linux] run-benchmark should be able to execute the benchmarks with more browsers"
href="show_bug.cgi?id=164792">bug 164792</a> it seems we can add a command line
> switch to avoid issuing the killall, so users that want to avoid this
> behaviour of the script can just activate the switch. And at the same time
> we can keep as default behaviour killing all process with name $browser.</span >
Alternatively, we can add an option like --kill-all to mean kill all existing browser instances to be used on bots.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>