[Webkit-unassigned] [Bug 164608] keyframes do not work when defined inside a style in a shadowRoot

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=164608

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #296138|review?                     |review+
              Flags|                            |

--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 296138
  --> https://bugs.webkit.org/attachment.cgi?id=296138
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296138&action=review

> Source/WebCore/page/animation/KeyframeAnimation.cpp:369
> +    auto* styleScope = Style::Scope::forOrdinal(element, m_animation->name().scopeOrdinal);
> +    if (styleScope)
> +        styleScope->resolver().keyframeStylesForAnimation(*m_object->element(), m_unanimatedStyle.get(), m_keyframes);

Could define the variable inside the if.

> Source/WebCore/platform/animation/Animation.cpp:167
> -const String& Animation::initialName()
> +Style::ScopedName Animation::initialName()
>  {
>      static NeverDestroyed<String> initialValue(ASCIILiteral("none"));
> -    return initialValue;
> +    return { initialValue.get(), Style::ScopeOrdinal::Element };
>  }

Could just have this return const Style::ScopedName& instead and have the global be a NeverDestroyed<Style::ScopedName>; would be slightly more efficient.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161205/aa536599/attachment.html>