<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - keyframes do not work when defined inside a style in a shadowRoot"
href="https://bugs.webkit.org/show_bug.cgi?id=164608">bug 164608</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #296138 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - keyframes do not work when defined inside a style in a shadowRoot"
href="https://bugs.webkit.org/show_bug.cgi?id=164608#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - keyframes do not work when defined inside a style in a shadowRoot"
href="https://bugs.webkit.org/show_bug.cgi?id=164608">bug 164608</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=296138&action=diff" name="attach_296138" title="patch">attachment 296138</a> <a href="attachment.cgi?id=296138&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=296138&action=review">https://bugs.webkit.org/attachment.cgi?id=296138&action=review</a>
<span class="quote">> Source/WebCore/page/animation/KeyframeAnimation.cpp:369
> + auto* styleScope = Style::Scope::forOrdinal(element, m_animation->name().scopeOrdinal);
> + if (styleScope)
> + styleScope->resolver().keyframeStylesForAnimation(*m_object->element(), m_unanimatedStyle.get(), m_keyframes);</span >
Could define the variable inside the if.
<span class="quote">> Source/WebCore/platform/animation/Animation.cpp:167
> -const String& Animation::initialName()
> +Style::ScopedName Animation::initialName()
> {
> static NeverDestroyed<String> initialValue(ASCIILiteral("none"));
> - return initialValue;
> + return { initialValue.get(), Style::ScopeOrdinal::Element };
> }</span >
Could just have this return const Style::ScopedName& instead and have the global be a NeverDestroyed<Style::ScopedName>; would be slightly more efficient.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>