[Webkit-unassigned] [Bug 165119] Add coordinate space to event streams and streamline tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=165119

--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 295543
  --> https://bugs.webkit.org/attachment.cgi?id=295543
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295543&action=review

> Tools/ChangeLog:9
> +        Update example script to more accurately show all the avaialble options.

s/avaialble/available/

> Tools/WebKitTestRunner/ios/HIDEventGenerator.h:54
> +// Values for

?

> Tools/WebKitTestRunner/ios/HIDEventGenerator.mm:63
> +NSString* const HIDEventCoordinateSpaceTypeContent = @"content";

technically there are a LOT of stars on the wrong side. but let's not fix in this patch.

> Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:211
> +            auto location = globalToContentCoordinates(TestController::singleton().mainWebView()->platformView(), (long)[touch[HIDEventXKey] doubleValue], (long)[touch[HIDEventYKey] doubleValue]);

Dot notation if you can.

> Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:212
> +            touch[HIDEventXKey] = [NSNumber numberWithFloat:location.x];

= @(location.x) maybe?

> Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:226
> +        if ([event[HIDEventCoordinateSpaceKey] isEqualToString:HIDEventCoordinateSpaceTypeContent]) {

early continue instead of a big indented block?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161202/a8e338fe/attachment-0001.html>