<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add coordinate space to event streams and streamline tests"
href="https://bugs.webkit.org/show_bug.cgi?id=165119#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add coordinate space to event streams and streamline tests"
href="https://bugs.webkit.org/show_bug.cgi?id=165119">bug 165119</a>
from <span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=295543&action=diff" name="attach_295543" title="Patch">attachment 295543</a> <a href="attachment.cgi?id=295543&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=295543&action=review">https://bugs.webkit.org/attachment.cgi?id=295543&action=review</a>
<span class="quote">> Tools/ChangeLog:9
> + Update example script to more accurately show all the avaialble options.</span >
s/avaialble/available/
<span class="quote">> Tools/WebKitTestRunner/ios/HIDEventGenerator.h:54
> +// Values for</span >
?
<span class="quote">> Tools/WebKitTestRunner/ios/HIDEventGenerator.mm:63
> +NSString* const HIDEventCoordinateSpaceTypeContent = @"content";</span >
technically there are a LOT of stars on the wrong side. but let's not fix in this patch.
<span class="quote">> Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:211
> + auto location = globalToContentCoordinates(TestController::singleton().mainWebView()->platformView(), (long)[touch[HIDEventXKey] doubleValue], (long)[touch[HIDEventYKey] doubleValue]);</span >
Dot notation if you can.
<span class="quote">> Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:212
> + touch[HIDEventXKey] = [NSNumber numberWithFloat:location.x];</span >
= @(location.x) maybe?
<span class="quote">> Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:226
> + if ([event[HIDEventCoordinateSpaceKey] isEqualToString:HIDEventCoordinateSpaceTypeContent]) {</span >
early continue instead of a big indented block?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>