[Webkit-unassigned] [Bug 160095] Web Inspector: Frontend should have access to Resource Timing information

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 25 19:12:09 PDT 2016


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #287053|review?                     |review-
              Flags|                            |

--- Comment #12 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 287053
  --> https://bugs.webkit.org/attachment.cgi?id=287053

View in context: https://bugs.webkit.org/attachment.cgi?id=287053&action=review

r- to see another patch without the WebInspectorUI changes.

> Source/WebInspectorUI/ChangeLog:11
> +        * UserInterface/Controllers/FrameResourceManager.js:
> +        (WebInspector.FrameResourceManager.prototype.resourceRequestWasServedFromMemoryCache):
> +        (WebInspector.FrameResourceManager.prototype.resourceRequestDidReceiveResponse):
> +        Push timing data to the Resource.

This looks like it should be done as a separate patch. updateResource doesn't do anything with this parameter yet.

When we do this, we will want to include a test for it.

>> Source/WebCore/inspector/InspectorNetworkAgent.cpp:190
>> +    double startTimeInInspector = m_environment.executionStopwatch()->elapsedTimeSinceMonotonicTime(monotonicTime);
> Why does executionStopwatch() return a Ref<Stopwatch> instead of a Stopwatch& ?

No reason, we should change it to return a Stopwatch&.

> Source/WebCore/inspector/InspectorNetworkAgent.cpp:399
> +    double elapsedFinishTime = timestamp();
> +    if (finishTime)
> +        elapsedFinishTime = m_environment.executionStopwatch()->elapsedTimeSinceMonotonicTime(finishTime);

Lets use s ternary to avoid potentially always calling timestamp():

    double elapsedFinishTime = finishTime ? m_environment.executionStopwatch()->elapsedTimeSinceMonotonicTime(finishTime) : timestamp();

> Source/WebCore/inspector/InspectorNetworkAgent.h:54
> +class NetworkLoadTiming;

Nit: Should be sorted.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160826/f4eb7534/attachment-0001.html>

More information about the webkit-unassigned mailing list