<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:joepeck@webkit.org" title="Joseph Pecoraro <joepeck@webkit.org>"> <span class="fn">Joseph Pecoraro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Frontend should have access to Resource Timing information"
href="https://bugs.webkit.org/show_bug.cgi?id=160095">bug 160095</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #287053 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Frontend should have access to Resource Timing information"
href="https://bugs.webkit.org/show_bug.cgi?id=160095#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Frontend should have access to Resource Timing information"
href="https://bugs.webkit.org/show_bug.cgi?id=160095">bug 160095</a>
from <span class="vcard"><a class="email" href="mailto:joepeck@webkit.org" title="Joseph Pecoraro <joepeck@webkit.org>"> <span class="fn">Joseph Pecoraro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=287053&action=diff" name="attach_287053" title="Patch">attachment 287053</a> <a href="attachment.cgi?id=287053&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=287053&action=review">https://bugs.webkit.org/attachment.cgi?id=287053&action=review</a>
r- to see another patch without the WebInspectorUI changes.
<span class="quote">> Source/WebInspectorUI/ChangeLog:11
> + * UserInterface/Controllers/FrameResourceManager.js:
> + (WebInspector.FrameResourceManager.prototype.resourceRequestWasServedFromMemoryCache):
> + (WebInspector.FrameResourceManager.prototype.resourceRequestDidReceiveResponse):
> + Push timing data to the Resource.</span >
This looks like it should be done as a separate patch. updateResource doesn't do anything with this parameter yet.
When we do this, we will want to include a test for it.
<span class="quote">>> Source/WebCore/inspector/InspectorNetworkAgent.cpp:190
>> + double startTimeInInspector = m_environment.executionStopwatch()->elapsedTimeSinceMonotonicTime(monotonicTime);
>
> Why does executionStopwatch() return a Ref<Stopwatch> instead of a Stopwatch& ?</span >
No reason, we should change it to return a Stopwatch&.
<span class="quote">> Source/WebCore/inspector/InspectorNetworkAgent.cpp:399
> + double elapsedFinishTime = timestamp();
> + if (finishTime)
> + elapsedFinishTime = m_environment.executionStopwatch()->elapsedTimeSinceMonotonicTime(finishTime);</span >
Lets use s ternary to avoid potentially always calling timestamp():
double elapsedFinishTime = finishTime ? m_environment.executionStopwatch()->elapsedTimeSinceMonotonicTime(finishTime) : timestamp();
<span class="quote">> Source/WebCore/inspector/InspectorNetworkAgent.h:54
> +class NetworkLoadTiming;</span >
Nit: Should be sorted.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>