[Webkit-unassigned] [Bug 161068] Update the Resource Timing implementation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 23 15:44:35 PDT 2016


Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
 Attachment #286776|review?                     |review-
              Flags|                            |

--- Comment #19 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 286776
  --> https://bugs.webkit.org/attachment.cgi?id=286776

View in context: https://bugs.webkit.org/attachment.cgi?id=286776&action=review

> Source/WebCore/loader/LoadTiming.cpp:54
> +    , m_isCached(false)

These should be in the header.
m_isCached { false };

> Source/WebCore/loader/ResourceLoader.h:144
> +    LoadTiming& loadTiming() { return m_loadTiming; }

Can this be const?

> Source/WebCore/loader/SubresourceLoader.cpp:463
> +    finishTime = monotonicallyIncreasingTime();

We should probably report this time in didFail, too.  Or at least something interesting.
Also, finishTime is a double that is a parameter coming from somewhere.  It might already have the current time.

// FIXME: ...
double realFinishTime = ...

Same in InspectorNetworkAgent::didFinishLoading

> Source/WebCore/page/PerformanceResourceTiming.cpp:173
> +    if (m_loadTiming.isCached())
> +        return connectStart();

These seem suspicious.  I think this is covering up a problem.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160823/bb8fe2c8/attachment.html>

More information about the webkit-unassigned mailing list