<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Update the Resource Timing implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=161068">bug 161068</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #286776 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Update the Resource Timing implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=161068#c19">Comment # 19</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Update the Resource Timing implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=161068">bug 161068</a>
from <span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=286776&action=diff" name="attach_286776" title="Patch">attachment 286776</a> <a href="attachment.cgi?id=286776&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=286776&action=review">https://bugs.webkit.org/attachment.cgi?id=286776&action=review</a>
<span class="quote">> Source/WebCore/loader/LoadTiming.cpp:54
> + , m_isCached(false)</span >
These should be in the header.
m_isCached { false };
<span class="quote">> Source/WebCore/loader/ResourceLoader.h:144
> + LoadTiming& loadTiming() { return m_loadTiming; }</span >
Can this be const?
<span class="quote">> Source/WebCore/loader/SubresourceLoader.cpp:463
> + finishTime = monotonicallyIncreasingTime();</span >
We should probably report this time in didFail, too. Or at least something interesting.
Also, finishTime is a double that is a parameter coming from somewhere. It might already have the current time.
// FIXME: ...
UNUSED_PARAM(finishTime);
double realFinishTime = ...
Same in InspectorNetworkAgent::didFinishLoading
<span class="quote">> Source/WebCore/page/PerformanceResourceTiming.cpp:173
> + if (m_loadTiming.isCached())
> + return connectStart();</span >
These seem suspicious. I think this is covering up a problem.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>