[Webkit-unassigned] [Bug 154808] NewRegexp should not prevent inlining

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=154808

--- Comment #9 from Caio Lima <ticaiolima at gmail.com> ---
(In reply to comment #8)
> Comment on attachment 286601 [details]
> Patch
> 
> You shouldn't be adding any new fields to CodeBlock. 
> 
> The DFG already has a mechanism for strongly marking objects known to the
> compiler such as the RegExps. It's called freezing: just do
> m_graph.freezeStrongly(...). 
> 
> You don't need to record the RegExp object anywhere other than the NewRegExp
> node. That node should not have an index into any vectors. It should just
> hold a pointer to RegExp. We already do this for other node types. See for
> example Node::cellOperand(). Notice that its already compatible with
> freezing.

Thank you for this info. I really didn't know about that. I took a look in code using the freezing and it looks simpler and more correct than my current patch. Just for curiosity, as I understood, this Freeze mechanism interact with the GC, right? If yes, How does it happen?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160823/84659529/attachment.html>