<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - NewRegexp should not prevent inlining"
href="https://bugs.webkit.org/show_bug.cgi?id=154808#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - NewRegexp should not prevent inlining"
href="https://bugs.webkit.org/show_bug.cgi?id=154808">bug 154808</a>
from <span class="vcard"><a class="email" href="mailto:ticaiolima@gmail.com" title="Caio Lima <ticaiolima@gmail.com>"> <span class="fn">Caio Lima</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=154808#c8">comment #8</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=286601&action=diff" name="attach_286601" title="Patch">attachment 286601</a> <a href="attachment.cgi?id=286601&action=edit" title="Patch">[details]</a></span>
> Patch
>
> You shouldn't be adding any new fields to CodeBlock.
>
> The DFG already has a mechanism for strongly marking objects known to the
> compiler such as the RegExps. It's called freezing: just do
> m_graph.freezeStrongly(...).
>
> You don't need to record the RegExp object anywhere other than the NewRegExp
> node. That node should not have an index into any vectors. It should just
> hold a pointer to RegExp. We already do this for other node types. See for
> example Node::cellOperand(). Notice that its already compatible with
> freezing.</span >
Thank you for this info. I really didn't know about that. I took a look in code using the freezing and it looks simpler and more correct than my current patch. Just for curiosity, as I understood, this Freeze mechanism interact with the GC, right? If yes, How does it happen?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>