[Webkit-unassigned] [Bug 160709] Move functionality common to Darwin ports into a base class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=160709

--- Comment #11 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 285675
  --> https://bugs.webkit.org/attachment.cgi?id=285675
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285675&action=review

>>>> Tools/Scripts/webkitpy/port/darwin.py:199
>>>> +        return fallback
>>> 
>>> This does not seem correct. We can and should make use of xcrun to find command line tools for both the Mac and iOS ports.
>> 
>> We do use xcrun for both Mac and iOS, but iOS assumes it's being run through a simulator, so it has a few extra arguments.  ios.py line 400 has the iOS simulator xcrun.
> 
> Can we share more of the common code from MacPort.xcrun_find() and IOSPort.xcrun_find()?

So, just for reference (since the IOS xcrun isn't on this revision, here is that function definition:

# iOS xcrun_find(...) definition
def xcrun_find(self, command, fallback=None):
        fallback = fallback or command
        try:
            return self._executive.run_command(['xcrun', '--sdk', 'iphonesimulator', '-find', command]).rstrip()
        except ScriptError:
            _log.warn("xcrun failed; falling back to '%s'." % fallback)
            return fallback

I think that xcrun_find should remain separate in the two ports, particularly since we may be creating a port for an iOS device, which would use an xcrun_find similar to iOS, but targeting the device instead of the simulator.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160823/1da4611d/attachment.html>