<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Move functionality common to Darwin ports into a base class"
href="https://bugs.webkit.org/show_bug.cgi?id=160709#c11">Comment # 11</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Move functionality common to Darwin ports into a base class"
href="https://bugs.webkit.org/show_bug.cgi?id=160709">bug 160709</a>
from <span class="vcard"><a class="email" href="mailto:jbedard@apple.com" title="Jonathan Bedard <jbedard@apple.com>"> <span class="fn">Jonathan Bedard</span></a>
</span></b>
<pre>Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=285675&action=diff" name="attach_285675" title="Patch">attachment 285675</a> <a href="attachment.cgi?id=285675&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=285675&action=review">https://bugs.webkit.org/attachment.cgi?id=285675&action=review</a>
<span class="quote">>>>> Tools/Scripts/webkitpy/port/darwin.py:199
>>>> + return fallback
>>>
>>> This does not seem correct. We can and should make use of xcrun to find command line tools for both the Mac and iOS ports.
>>
>> We do use xcrun for both Mac and iOS, but iOS assumes it's being run through a simulator, so it has a few extra arguments. ios.py line 400 has the iOS simulator xcrun.
>
> Can we share more of the common code from MacPort.xcrun_find() and IOSPort.xcrun_find()?</span >
So, just for reference (since the IOS xcrun isn't on this revision, here is that function definition:
# iOS xcrun_find(...) definition
def xcrun_find(self, command, fallback=None):
fallback = fallback or command
try:
return self._executive.run_command(['xcrun', '--sdk', 'iphonesimulator', '-find', command]).rstrip()
except ScriptError:
_log.warn("xcrun failed; falling back to '%s'." % fallback)
return fallback
I think that xcrun_find should remain separate in the two ports, particularly since we may be creating a port for an iOS device, which would use an xcrun_find similar to iOS, but targeting the device instead of the simulator.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>