[Webkit-unassigned] [Bug 160963] Resource Timing: Make PerformanceEntryList a sequence as per spec

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=160963

--- Comment #5 from Johan K. Jensen <johan_jensen at apple.com> ---
(In reply to comment #2)
> > Source/WebCore/page/Performance.cpp:92
> > -RefPtr<PerformanceEntryList> Performance::getEntries() const
> > +Vector<RefPtr<PerformanceEntry>> Performance::getEntries() const
> 
> Could these be Ref<PerformanceEntry>s?
Some of the User Timing code uses PassRefPtr, so it should probably be updated in another patch.
> 
> > Source/WebCore/page/Performance.cpp:105
> > +    std::sort(entries.begin(), entries.end(), PerformanceEntry::startTimeCompareLessThan);
> 
> do we have to sort everything?
Yes, per the spec we should sort them by start time. Entries gets added according to responseEnd.

(In reply to comment #3)
> > LayoutTests/http/tests/performance/performance-resource-timing-entries-iterable-expected.txt:1
> > +PASS resources is an instance of Array
> 
> Would be nice if this test had a description.
Ah, yeah.

(In reply to comment #4)
> > Source/WebCore/page/Performance.h:67
> > +    Vector<RefPtr<PerformanceEntry>> getEntriesByType(const String& entryType);
> 
> Why is this not const?
Hm... Don’t see any reason why it isn’t.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160818/37c2a844/attachment.html>