<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Resource Timing: Make PerformanceEntryList a sequence as per spec"
href="https://bugs.webkit.org/show_bug.cgi?id=160963#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Resource Timing: Make PerformanceEntryList a sequence as per spec"
href="https://bugs.webkit.org/show_bug.cgi?id=160963">bug 160963</a>
from <span class="vcard"><a class="email" href="mailto:johan_jensen@apple.com" title="Johan K. Jensen <johan_jensen@apple.com>"> <span class="fn">Johan K. Jensen</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=160963#c2">comment #2</a>)
<span class="quote">> > Source/WebCore/page/Performance.cpp:92
> > -RefPtr<PerformanceEntryList> Performance::getEntries() const
> > +Vector<RefPtr<PerformanceEntry>> Performance::getEntries() const
>
> Could these be Ref<PerformanceEntry>s?</span >
Some of the User Timing code uses PassRefPtr, so it should probably be updated in another patch.
<span class="quote">>
> > Source/WebCore/page/Performance.cpp:105
> > + std::sort(entries.begin(), entries.end(), PerformanceEntry::startTimeCompareLessThan);
>
> do we have to sort everything?</span >
Yes, per the spec we should sort them by start time. Entries gets added according to responseEnd.
(In reply to <a href="show_bug.cgi?id=160963#c3">comment #3</a>)
<span class="quote">> > LayoutTests/http/tests/performance/performance-resource-timing-entries-iterable-expected.txt:1
> > +PASS resources is an instance of Array
>
> Would be nice if this test had a description.</span >
Ah, yeah.
(In reply to <a href="show_bug.cgi?id=160963#c4">comment #4</a>)
<span class="quote">> > Source/WebCore/page/Performance.h:67
> > + Vector<RefPtr<PerformanceEntry>> getEntriesByType(const String& entryType);
>
> Why is this not const?</span >
Hm... Don’t see any reason why it isn’t.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>