[Webkit-unassigned] [Bug 160709] Refactor of Webkitpy Ports

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 18 12:09:16 PDT 2016


--- Comment #4 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 285675
  --> https://bugs.webkit.org/attachment.cgi?id=285675

View in context: https://bugs.webkit.org/attachment.cgi?id=285675&action=review

> Tools/Scripts/webkitpy/port/darwin.py:59
> +    def supports_per_test_timeout(self):
> +        return True

Following the move of this method from class ApplePort to DarwinPort, the supports_per_test_timeout() returns False for the Windows port by <https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/port/base.py?rev=204603#L155>. It looks like all ports support per test timeouts. So, we should change the base class implementation to remove True and remove all the port-specific overrides.

> Tools/Scripts/webkitpy/port/darwin.py:199
> +    def xcrun_find(self, command, fallback):
> +        _log.warn("xcrun undefined; falling back to '%s'." % fallback)
> +        return fallback

This does not seem correct. We can and should make use of xcrun to find command line tools for both the Mac and iOS ports.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160818/a9664698/attachment-0001.html>

More information about the webkit-unassigned mailing list