<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Refactor of Webkitpy Ports"
href="https://bugs.webkit.org/show_bug.cgi?id=160709#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Refactor of Webkitpy Ports"
href="https://bugs.webkit.org/show_bug.cgi?id=160709">bug 160709</a>
from <span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=285675&action=diff" name="attach_285675" title="Patch">attachment 285675</a> <a href="attachment.cgi?id=285675&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=285675&action=review">https://bugs.webkit.org/attachment.cgi?id=285675&action=review</a>
<span class="quote">> Tools/Scripts/webkitpy/port/darwin.py:59
> + def supports_per_test_timeout(self):
> + return True</span >
Following the move of this method from class ApplePort to DarwinPort, the supports_per_test_timeout() returns False for the Windows port by <<a href="https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/port/base.py?rev=204603#L155">https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/port/base.py?rev=204603#L155</a>>. It looks like all ports support per test timeouts. So, we should change the base class implementation to remove True and remove all the port-specific overrides.
<span class="quote">> Tools/Scripts/webkitpy/port/darwin.py:199
> + def xcrun_find(self, command, fallback):
> + _log.warn("xcrun undefined; falling back to '%s'." % fallback)
> + return fallback</span >
This does not seem correct. We can and should make use of xcrun to find command line tools for both the Mac and iOS ports.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>