[Webkit-unassigned] [Bug 160904] Use find_library within Windows build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=160904

--- Comment #13 from Don Olmstead <don.olmstead at am.sony.com> ---
(In reply to comment #11)
> Comment on attachment 286250 [details]
> FindICU with comments
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=286250&action=review
> 
> I can confirm that this patch builds properly on a local Windows development
> machine. The build failure was due to an existing WIndows problem that has
> since been fixed.
> 
> Note that we need to land Bug 160949 before this one.
> 
> > Source/cmake/FindICU.cmake:82
> > +        set(ICU_DATA_LIBRARIES)
> 
> I wonder if set(ICU_DATA_LIBRARIES ${ICU_DATA_LIBRARY}) just does the right
> thing in the case of no ICU_DATA_LIBRARY value...

It should. In our setup we have the data libraries and it works fine. On WinCairo it didnt find them and I don't see it in the Additional Dependencies within VS.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160817/f6938ff8/attachment.html>