<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Use find_library within Windows build"
href="https://bugs.webkit.org/show_bug.cgi?id=160904#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Use find_library within Windows build"
href="https://bugs.webkit.org/show_bug.cgi?id=160904">bug 160904</a>
from <span class="vcard"><a class="email" href="mailto:don.olmstead@am.sony.com" title="Don Olmstead <don.olmstead@am.sony.com>"> <span class="fn">Don Olmstead</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=160904#c11">comment #11</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=286250&action=diff" name="attach_286250" title="FindICU with comments">attachment 286250</a> <a href="attachment.cgi?id=286250&action=edit" title="FindICU with comments">[details]</a></span>
> FindICU with comments
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=286250&action=review">https://bugs.webkit.org/attachment.cgi?id=286250&action=review</a>
>
> I can confirm that this patch builds properly on a local Windows development
> machine. The build failure was due to an existing WIndows problem that has
> since been fixed.
>
> Note that we need to land <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Win] Remove old libraries from build inputs"
href="show_bug.cgi?id=160949">Bug 160949</a> before this one.
>
> > Source/cmake/FindICU.cmake:82
> > + set(ICU_DATA_LIBRARIES)
>
> I wonder if set(ICU_DATA_LIBRARIES ${ICU_DATA_LIBRARY}) just does the right
> thing in the case of no ICU_DATA_LIBRARY value...</span >
It should. In our setup we have the data libraries and it works fine. On WinCairo it didnt find them and I don't see it in the Additional Dependencies within VS.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>