[Webkit-unassigned] [Bug 160904] Use find_library within Windows build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=160904

--- Comment #7 from Don Olmstead <don.olmstead at am.sony.com> ---
(In reply to comment #6)
> Comment on attachment 286228 [details]
> FindICU fixes
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=286228&action=review
> 
> This needs a ChangeLog entry.  Please use Tools/Scripts/prepare-ChangeLog to
> generate templates.
> 

Still working my way around prepare-Changelog. Should have the hang of it soon.

> > Source/cmake/OptionsWin.cmake:106
> > +    # TODO Remove ${WEBKIT_LIBRARIES_LINK_DIR} when find_library is used for everything
> 
> FIXME: is used in WebKit.
> 
> > Source/cmake/OptionsWin.cmake:113
> > +include(WebKitLibraries)
> 
> The contents of WebKitLibraries.cmake should probably just go here instead
> of making another file.
> 

I had planned on using the file within our out of trunk port till it can land. I've been following the same conventions within it.

> > Source/cmake/OptionsWin.cmake:115
> > +include_directories("${CMAKE_BINARY_DIR}/DerivedSources/ForwardingHeaders" "${CMAKE_BINARY_DIR}/DerivedSources" "${WEBKIT_LIBRARIES_INCLUDE_DIR}")
> 
> This should not be here.

Not sure what you mean here. It should be equivalent to what was at that position.

> 
> > Source/cmake/OptionsWinCairo.cmake:5
> > +find_package(ICU REQUIRED)
> 
> This is needed for AppleWin, too.
> 

I'll move it to OptionsWin.

> > Source/cmake/WebKitLibraries.cmake:17
> > +        set(WEBKIT_LIBRARIES_LINK_DIR "${WEBKIT_LIBRARIES_DIR}/lib")
> 
> If this were in OptionsWin, it would be more obvious that this only applies
> when building for your port.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160816/06e15dd4/attachment.html>