<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Use find_library within Windows build"
   href="https://bugs.webkit.org/show_bug.cgi?id=160904#c7">Comment # 7</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Use find_library within Windows build"
   href="https://bugs.webkit.org/show_bug.cgi?id=160904">bug 160904</a>
              from <span class="vcard"><a class="email" href="mailto:don.olmstead&#64;am.sony.com" title="Don Olmstead &lt;don.olmstead&#64;am.sony.com&gt;"> <span class="fn">Don Olmstead</span></a>
</span></b>
        <pre>(In reply to <a href="show_bug.cgi?id=160904#c6">comment #6</a>)
<span class="quote">&gt; Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=286228&amp;action=diff" name="attach_286228" title="FindICU fixes">attachment 286228</a> <a href="attachment.cgi?id=286228&amp;action=edit" title="FindICU fixes">[details]</a></span>
&gt; FindICU fixes
&gt; 
&gt; View in context:
&gt; <a href="https://bugs.webkit.org/attachment.cgi?id=286228&amp;action=review">https://bugs.webkit.org/attachment.cgi?id=286228&amp;action=review</a>
&gt; 
&gt; This needs a ChangeLog entry.  Please use Tools/Scripts/prepare-ChangeLog to
&gt; generate templates.
&gt; </span >

Still working my way around prepare-Changelog. Should have the hang of it soon.

<span class="quote">&gt; &gt; Source/cmake/OptionsWin.cmake:106
&gt; &gt; +    # TODO Remove ${WEBKIT_LIBRARIES_LINK_DIR} when find_library is used for everything
&gt; 
&gt; FIXME: is used in WebKit.
&gt; 
&gt; &gt; Source/cmake/OptionsWin.cmake:113
&gt; &gt; +include(WebKitLibraries)
&gt; 
&gt; The contents of WebKitLibraries.cmake should probably just go here instead
&gt; of making another file.
&gt; </span >

I had planned on using the file within our out of trunk port till it can land. I've been following the same conventions within it.

<span class="quote">&gt; &gt; Source/cmake/OptionsWin.cmake:115
&gt; &gt; +include_directories(&quot;${CMAKE_BINARY_DIR}/DerivedSources/ForwardingHeaders&quot; &quot;${CMAKE_BINARY_DIR}/DerivedSources&quot; &quot;${WEBKIT_LIBRARIES_INCLUDE_DIR}&quot;)
&gt; 
&gt; This should not be here.</span >

Not sure what you mean here. It should be equivalent to what was at that position.

<span class="quote">&gt; 
&gt; &gt; Source/cmake/OptionsWinCairo.cmake:5
&gt; &gt; +find_package(ICU REQUIRED)
&gt; 
&gt; This is needed for AppleWin, too.
&gt; </span >

I'll move it to OptionsWin.

<span class="quote">&gt; &gt; Source/cmake/WebKitLibraries.cmake:17
&gt; &gt; +        set(WEBKIT_LIBRARIES_LINK_DIR &quot;${WEBKIT_LIBRARIES_DIR}/lib&quot;)
&gt; 
&gt; If this were in OptionsWin, it would be more obvious that this only applies
&gt; when building for your port.</span ></pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>