<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Use find_library within Windows build"
href="https://bugs.webkit.org/show_bug.cgi?id=160904#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Use find_library within Windows build"
href="https://bugs.webkit.org/show_bug.cgi?id=160904">bug 160904</a>
from <span class="vcard"><a class="email" href="mailto:don.olmstead@am.sony.com" title="Don Olmstead <don.olmstead@am.sony.com>"> <span class="fn">Don Olmstead</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=160904#c6">comment #6</a>)
<span class="quote">> Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=286228&action=diff" name="attach_286228" title="FindICU fixes">attachment 286228</a> <a href="attachment.cgi?id=286228&action=edit" title="FindICU fixes">[details]</a></span>
> FindICU fixes
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=286228&action=review">https://bugs.webkit.org/attachment.cgi?id=286228&action=review</a>
>
> This needs a ChangeLog entry. Please use Tools/Scripts/prepare-ChangeLog to
> generate templates.
> </span >
Still working my way around prepare-Changelog. Should have the hang of it soon.
<span class="quote">> > Source/cmake/OptionsWin.cmake:106
> > + # TODO Remove ${WEBKIT_LIBRARIES_LINK_DIR} when find_library is used for everything
>
> FIXME: is used in WebKit.
>
> > Source/cmake/OptionsWin.cmake:113
> > +include(WebKitLibraries)
>
> The contents of WebKitLibraries.cmake should probably just go here instead
> of making another file.
> </span >
I had planned on using the file within our out of trunk port till it can land. I've been following the same conventions within it.
<span class="quote">> > Source/cmake/OptionsWin.cmake:115
> > +include_directories("${CMAKE_BINARY_DIR}/DerivedSources/ForwardingHeaders" "${CMAKE_BINARY_DIR}/DerivedSources" "${WEBKIT_LIBRARIES_INCLUDE_DIR}")
>
> This should not be here.</span >
Not sure what you mean here. It should be equivalent to what was at that position.
<span class="quote">>
> > Source/cmake/OptionsWinCairo.cmake:5
> > +find_package(ICU REQUIRED)
>
> This is needed for AppleWin, too.
> </span >
I'll move it to OptionsWin.
<span class="quote">> > Source/cmake/WebKitLibraries.cmake:17
> > + set(WEBKIT_LIBRARIES_LINK_DIR "${WEBKIT_LIBRARIES_DIR}/lib")
>
> If this were in OptionsWin, it would be more obvious that this only applies
> when building for your port.</span ></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>