[Webkit-unassigned] [Bug 160904] Use find_library within Windows build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=160904

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #286228|1                           |0
        is obsolete|                            |

--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 286228
  --> https://bugs.webkit.org/attachment.cgi?id=286228
FindICU fixes

View in context: https://bugs.webkit.org/attachment.cgi?id=286228&action=review

This needs a ChangeLog entry.  Please use Tools/Scripts/prepare-ChangeLog to generate templates.

> Source/cmake/OptionsWin.cmake:106
> +    # TODO Remove ${WEBKIT_LIBRARIES_LINK_DIR} when find_library is used for everything

FIXME: is used in WebKit.

> Source/cmake/OptionsWin.cmake:113
> +include(WebKitLibraries)

The contents of WebKitLibraries.cmake should probably just go here instead of making another file.

> Source/cmake/OptionsWin.cmake:115
> +include_directories("${CMAKE_BINARY_DIR}/DerivedSources/ForwardingHeaders" "${CMAKE_BINARY_DIR}/DerivedSources" "${WEBKIT_LIBRARIES_INCLUDE_DIR}")

This should not be here.

> Source/cmake/OptionsWinCairo.cmake:5
> +find_package(ICU REQUIRED)

This is needed for AppleWin, too.

> Source/cmake/WebKitLibraries.cmake:17
> +        set(WEBKIT_LIBRARIES_LINK_DIR "${WEBKIT_LIBRARIES_DIR}/lib")

If this were in OptionsWin, it would be more obvious that this only applies when building for your port.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160816/9c14905b/attachment.html>