<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Use find_library within Windows build"
href="https://bugs.webkit.org/show_bug.cgi?id=160904">bug 160904</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #286228 is obsolete</td>
<td>1
</td>
<td>
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Use find_library within Windows build"
href="https://bugs.webkit.org/show_bug.cgi?id=160904#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Use find_library within Windows build"
href="https://bugs.webkit.org/show_bug.cgi?id=160904">bug 160904</a>
from <span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=286228&action=diff" name="attach_286228" title="FindICU fixes">attachment 286228</a> <a href="attachment.cgi?id=286228&action=edit" title="FindICU fixes">[details]</a></span>
FindICU fixes
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=286228&action=review">https://bugs.webkit.org/attachment.cgi?id=286228&action=review</a>
This needs a ChangeLog entry. Please use Tools/Scripts/prepare-ChangeLog to generate templates.
<span class="quote">> Source/cmake/OptionsWin.cmake:106
> + # TODO Remove ${WEBKIT_LIBRARIES_LINK_DIR} when find_library is used for everything</span >
FIXME: is used in WebKit.
<span class="quote">> Source/cmake/OptionsWin.cmake:113
> +include(WebKitLibraries)</span >
The contents of WebKitLibraries.cmake should probably just go here instead of making another file.
<span class="quote">> Source/cmake/OptionsWin.cmake:115
> +include_directories("${CMAKE_BINARY_DIR}/DerivedSources/ForwardingHeaders" "${CMAKE_BINARY_DIR}/DerivedSources" "${WEBKIT_LIBRARIES_INCLUDE_DIR}")</span >
This should not be here.
<span class="quote">> Source/cmake/OptionsWinCairo.cmake:5
> +find_package(ICU REQUIRED)</span >
This is needed for AppleWin, too.
<span class="quote">> Source/cmake/WebKitLibraries.cmake:17
> + set(WEBKIT_LIBRARIES_LINK_DIR "${WEBKIT_LIBRARIES_DIR}/lib")</span >
If this were in OptionsWin, it would be more obvious that this only applies when building for your port.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>