[Webkit-unassigned] [Bug 160871] Cleanup WK2 platform gamepad handling
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 15 21:01:24 PDT 2016
https://bugs.webkit.org/show_bug.cgi?id=160871
--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 286103
--> https://bugs.webkit.org/attachment.cgi?id=286103
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=286103&action=review
> Source/WebCore/platform/gamepad/GamepadProviderClient.h:40
> + virtual void setInitialConnectedGamepads(const Vector<PlatformGamepad*>&) { }
I don't understand the lifetime of these PlatformGamepads. Where do they come from? How do we know they will still be alive as long as we have pointers to them?
> Source/WebKit2/UIProcess/Gamepad/UIGamepadProvider.h:87
> + bool m_hasInitialGamepads { false };
This is only used in an assertion. Could be compiled out. Probably nbd
> Source/WebKit2/WebProcess/WebProcess.cpp:1036
> +void WebProcess::setInitialGamepads(const Vector<WebKit::GamepadData>& gamepadDatas)
data is already plural
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160816/0b3d1334/attachment-0001.html>
More information about the webkit-unassigned
mailing list