<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Cleanup WK2 platform gamepad handling"
   href="https://bugs.webkit.org/show_bug.cgi?id=160871#c2">Comment # 2</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Cleanup WK2 platform gamepad handling"
   href="https://bugs.webkit.org/show_bug.cgi?id=160871">bug 160871</a>
              from <span class="vcard"><a class="email" href="mailto:achristensen&#64;apple.com" title="Alex Christensen &lt;achristensen&#64;apple.com&gt;"> <span class="fn">Alex Christensen</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=286103&amp;action=diff" name="attach_286103" title="Patch">attachment 286103</a> <a href="attachment.cgi?id=286103&amp;action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=286103&amp;action=review">https://bugs.webkit.org/attachment.cgi?id=286103&amp;action=review</a>

<span class="quote">&gt; Source/WebCore/platform/gamepad/GamepadProviderClient.h:40
&gt; +    virtual void setInitialConnectedGamepads(const Vector&lt;PlatformGamepad*&gt;&amp;) { }</span >

I don't understand the lifetime of these PlatformGamepads.  Where do they come from?  How do we know they will still be alive as long as we have pointers to them?

<span class="quote">&gt; Source/WebKit2/UIProcess/Gamepad/UIGamepadProvider.h:87
&gt; +    bool m_hasInitialGamepads { false };</span >

This is only used in an assertion.  Could be compiled out.  Probably nbd

<span class="quote">&gt; Source/WebKit2/WebProcess/WebProcess.cpp:1036
&gt; +void WebProcess::setInitialGamepads(const Vector&lt;WebKit::GamepadData&gt;&amp; gamepadDatas)</span >

data is already plural</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>