[Webkit-unassigned] [Bug 160830] Binding NULL pointer to reference in WebCore::RenderObject

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 12 16:36:21 PDT 2016


--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 285969
  --> https://bugs.webkit.org/attachment.cgi?id=285969

View in context: https://bugs.webkit.org/attachment.cgi?id=285969&action=review

> Source/WebCore/rendering/line/BreakingContext.h:170
> +    void commitLineBreakAtCurrentWidth(RenderObject* object, unsigned offset = 0, int nextBreak = -1)

I understand the motivation for changing from a pointer to a reference to fix the compiler warning on line 1228 in BreakingContext::commitAndUpdateLineBreakIfNeeded(), but is this preferred way to allow moving to the end of the iterator (assuming the code in BreakingContext::commitAndUpdateLineBreakIfNeeded() is correct)? Does anyone ever call this function or InlineIterator::moveTo(RenderObject*, unsigned, int) with a null RenderObject and a non-zero offset? What does it mean to support such calls?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160812/5059bb41/attachment.html>

More information about the webkit-unassigned mailing list