<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Binding NULL pointer to reference in WebCore::RenderObject"
href="https://bugs.webkit.org/show_bug.cgi?id=160830#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Binding NULL pointer to reference in WebCore::RenderObject"
href="https://bugs.webkit.org/show_bug.cgi?id=160830">bug 160830</a>
from <span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=285969&action=diff" name="attach_285969" title="Patch">attachment 285969</a> <a href="attachment.cgi?id=285969&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=285969&action=review">https://bugs.webkit.org/attachment.cgi?id=285969&action=review</a>
<span class="quote">> Source/WebCore/rendering/line/BreakingContext.h:170
> + void commitLineBreakAtCurrentWidth(RenderObject* object, unsigned offset = 0, int nextBreak = -1)</span >
I understand the motivation for changing from a pointer to a reference to fix the compiler warning on line 1228 in BreakingContext::commitAndUpdateLineBreakIfNeeded(), but is this preferred way to allow moving to the end of the iterator (assuming the code in BreakingContext::commitAndUpdateLineBreakIfNeeded() is correct)? Does anyone ever call this function or InlineIterator::moveTo(RenderObject*, unsigned, int) with a null RenderObject and a non-zero offset? What does it mean to support such calls?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>