[Webkit-unassigned] [Bug 160412] [ES2016] Implement Object.entries

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=160412

Saam Barati <sbarati at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #285903|review?                     |review+
              Flags|                            |

--- Comment #11 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 285903
  --> https://bugs.webkit.org/attachment.cgi?id=285903
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285903&action=review

r=me

> JSTests/stress/object-entries.js:106
> +passed = arr2.length > 1 && arr2[0] === "ownKeys";

Can we make this assert exactly how lon the array is?

> JSTests/stress/object-entries.js:116
> +Array.prototype.push = function () { throw new Error("Array.prototype.push should not be used during invoking of Object.entries.")};

This is a good test. Can you also add one where you replace Reflect.getOwnPropertyDescriptor
to make sure the algorithm doesn't call that?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160812/1f5195a3/attachment-0001.html>