<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body><span class="vcard"><a class="email" href="mailto:sbarati&#64;apple.com" title="Saam Barati &lt;sbarati&#64;apple.com&gt;"> <span class="fn">Saam Barati</span></a>
</span> changed
              <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [ES2016] Implement Object.entries"
   href="https://bugs.webkit.org/show_bug.cgi?id=160412">bug 160412</a>
        <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">Attachment #285903 Flags</td>
           <td>review?
           </td>
           <td>review+
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [ES2016] Implement Object.entries"
   href="https://bugs.webkit.org/show_bug.cgi?id=160412#c11">Comment # 11</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [ES2016] Implement Object.entries"
   href="https://bugs.webkit.org/show_bug.cgi?id=160412">bug 160412</a>
              from <span class="vcard"><a class="email" href="mailto:sbarati&#64;apple.com" title="Saam Barati &lt;sbarati&#64;apple.com&gt;"> <span class="fn">Saam Barati</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=285903&amp;action=diff" name="attach_285903" title="Patch">attachment 285903</a> <a href="attachment.cgi?id=285903&amp;action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=285903&amp;action=review">https://bugs.webkit.org/attachment.cgi?id=285903&amp;action=review</a>

r=me

<span class="quote">&gt; JSTests/stress/object-entries.js:106
&gt; +passed = arr2.length &gt; 1 &amp;&amp; arr2[0] === &quot;ownKeys&quot;;</span >

Can we make this assert exactly how lon the array is?

<span class="quote">&gt; JSTests/stress/object-entries.js:116
&gt; +Array.prototype.push = function () { throw new Error(&quot;Array.prototype.push should not be used during invoking of Object.entries.&quot;)};</span >

This is a good test. Can you also add one where you replace Reflect.getOwnPropertyDescriptor
to make sure the algorithm doesn't call that?</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>