[Webkit-unassigned] [Bug 160764] [GStreamer][OWR] Video rendering fixes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=160764

--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 285821
  --> https://bugs.webkit.org/attachment.cgi?id=285821
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285821&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:346
> +    m_videoSink = sink;
> +#else
> +    GstElement* sink = gst_bin_new(nullptr);
> +    GstElement* gldownload = gst_element_factory_make("gldownload", nullptr);
> +    GstElement* videoconvert = gst_element_factory_make("videoconvert", nullptr);
> +    GstElement* webkitSink = MediaPlayerPrivateGStreamerBase::createVideoSink();
> +    gst_bin_add_many(GST_BIN(sink), gldownload, videoconvert, webkitSink, nullptr);
> +    gst_element_link_many(gldownload, videoconvert, webkitSink, nullptr);
> +    GRefPtr<GstPad> pad = gst_element_get_static_pad(gldownload, "sink");
> +    gst_element_add_pad(sink, gst_ghost_pad_new("sink", pad.get()));

Why are we keeping the m_videoSink for the if and not for the else?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160812/31755246/attachment.html>