<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer][OWR] Video rendering fixes"
href="https://bugs.webkit.org/show_bug.cgi?id=160764#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer][OWR] Video rendering fixes"
href="https://bugs.webkit.org/show_bug.cgi?id=160764">bug 160764</a>
from <span class="vcard"><a class="email" href="mailto:calvaris@igalia.com" title="Xabier RodrÃguez Calvar <calvaris@igalia.com>"> <span class="fn">Xabier RodrÃguez Calvar</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=285821&action=diff" name="attach_285821" title="patch">attachment 285821</a> <a href="attachment.cgi?id=285821&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=285821&action=review">https://bugs.webkit.org/attachment.cgi?id=285821&action=review</a>
<span class="quote">> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:346
> + m_videoSink = sink;
> +#else
> + GstElement* sink = gst_bin_new(nullptr);
> + GstElement* gldownload = gst_element_factory_make("gldownload", nullptr);
> + GstElement* videoconvert = gst_element_factory_make("videoconvert", nullptr);
> + GstElement* webkitSink = MediaPlayerPrivateGStreamerBase::createVideoSink();
> + gst_bin_add_many(GST_BIN(sink), gldownload, videoconvert, webkitSink, nullptr);
> + gst_element_link_many(gldownload, videoconvert, webkitSink, nullptr);
> + GRefPtr<GstPad> pad = gst_element_get_static_pad(gldownload, "sink");
> + gst_element_add_pad(sink, gst_ghost_pad_new("sink", pad.get()));</span >
Why are we keeping the m_videoSink for the if and not for the else?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>