[Webkit-unassigned] [Bug 160723] Web Inspector: Data grid has a double left border when the first column is hidden

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=160723

Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #285703|review?                     |review+
              Flags|                            |

--- Comment #5 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 285703
  --> https://bugs.webkit.org/attachment.cgi?id=285703
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285703&action=review

>>> Source/WebInspectorUI/UserInterface/Views/DataGrid.css:93
>>> +    background-image: linear-gradient(to right, transparent calc(100% - 0.5px), var(--border-color) 0.5px);
>> 
>> Is there a class we can use to set the border with to 0 when the column is hidden?
>> 
>> We would need to be careful with using background since this could conflict with other potential styling in the future. I also worry about performance aspects of using gradients like this — that is a lot of individual gradients.
> 
> We would have to add this class to every <td> in the column.
> 
> Currently, we change the width of a <col> element. We don't modify <td>'s directly.
> 
> <table class="data">
>   <colgroup>
>     <col style="width: 0%;">
>     ...
>   </colgroup>
>   <tbody>
>     <tr>
>       <td>...</td>
>     </tr>
>     ...
>   </tbody>
> </table>

We might want to just remove the hidden table cells and columns from the DOM. We can try this fix assuming it does not have any regressions found in testing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160810/0b94d9ab/attachment.html>