<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:timothy@apple.com" title="Timothy Hatcher <timothy@apple.com>"> <span class="fn">Timothy Hatcher</span></a>
</span> changed
<a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - Web Inspector: Data grid has a double left border when the first column is hidden"
href="https://bugs.webkit.org/show_bug.cgi?id=160723">bug 160723</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #285703 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - Web Inspector: Data grid has a double left border when the first column is hidden"
href="https://bugs.webkit.org/show_bug.cgi?id=160723#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - Web Inspector: Data grid has a double left border when the first column is hidden"
href="https://bugs.webkit.org/show_bug.cgi?id=160723">bug 160723</a>
from <span class="vcard"><a class="email" href="mailto:timothy@apple.com" title="Timothy Hatcher <timothy@apple.com>"> <span class="fn">Timothy Hatcher</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=285703&action=diff" name="attach_285703" title="Patch">attachment 285703</a> <a href="attachment.cgi?id=285703&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=285703&action=review">https://bugs.webkit.org/attachment.cgi?id=285703&action=review</a>
<span class="quote">>>> Source/WebInspectorUI/UserInterface/Views/DataGrid.css:93
>>> + background-image: linear-gradient(to right, transparent calc(100% - 0.5px), var(--border-color) 0.5px);
>>
>> Is there a class we can use to set the border with to 0 when the column is hidden?
>>
>> We would need to be careful with using background since this could conflict with other potential styling in the future. I also worry about performance aspects of using gradients like this — that is a lot of individual gradients.
>
> We would have to add this class to every <td> in the column.
>
> Currently, we change the width of a <col> element. We don't modify <td>'s directly.
>
> <table class="data">
> <colgroup>
> <col style="width: 0%;">
> ...
> </colgroup>
> <tbody>
> <tr>
> <td>...</td>
> </tr>
> ...
> </tbody>
> </table></span >
We might want to just remove the hidden table cells and columns from the DOM. We can try this fix assuming it does not have any regressions found in testing.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>