[Webkit-unassigned] [Bug 160619] AX: Media controls timeline should have percentage value description

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=160619

--- Comment #9 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 285708
  --> https://bugs.webkit.org/attachment.cgi?id=285708
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285708&action=review

> LayoutTests/ChangeLog:10
> +        * http/tests/media/resources/hls/test-video-duration-accessibility.php: Added.

This file isn't accessibility-specific, how about something like "generate-vod.php"?

> LayoutTests/http/tests/media/hls/video-duration-accessibility.html:36
> +                // We are not getting the exact same elapsed duration for hour cases, 
> +                // so let's special case this.

What does this mean, is it something we need to fix?

> LayoutTests/http/tests/media/hls/video-duration-accessibility.html:42
> +                if (elapsedTimer.description.indexOf("Hour") !== -1) {
> +                    testExpected("elapsedTimer.description.indexOf('1 Hour') !== -1 || elapsedTimer.description.indexOf('2 Hours') !== -1", true);
> +                } else {
> +                    consoleWrite("elapsedTimer.description: " + elapsedTimer.description);
> +                }
> +                

Nit: WebKit style is to not use braces for single line if statements.

> LayoutTests/http/tests/media/hls/video-duration-accessibility.html:47
> +                if (seekCount == seekTimes.length) {
> +                    endTest();
> +                } else {
> +                    video.fastSeek(seekTimes[seekCount]);
> +                }

Ditto.

> LayoutTests/http/tests/media/resources/hls/test-video-duration-accessibility.php:10
> +// header("Content-Length: " . filesize(__FILE__));

Nit: this isn't necessary.

> LayoutTests/http/tests/media/resources/hls/test-video-duration-accessibility.php:13
> +$chunkDuration = 6.0272;
> +$chunkCount = 1300;

I would prefer that the duration of the file come from an optional parameter so we can use this for other tests in the future. Something like (untested):

    $chunkCount = 1300;
    if (array_key_exists("duration", $_GET))
        $chunkCount = $_GET["duration"] / $chunkDuration;

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160810/e27a2864/attachment.html>