<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Media controls timeline should have percentage value description"
href="https://bugs.webkit.org/show_bug.cgi?id=160619#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Media controls timeline should have percentage value description"
href="https://bugs.webkit.org/show_bug.cgi?id=160619">bug 160619</a>
from <span class="vcard"><a class="email" href="mailto:eric.carlson@apple.com" title="Eric Carlson <eric.carlson@apple.com>"> <span class="fn">Eric Carlson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=285708&action=diff" name="attach_285708" title="patch">attachment 285708</a> <a href="attachment.cgi?id=285708&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=285708&action=review">https://bugs.webkit.org/attachment.cgi?id=285708&action=review</a>
<span class="quote">> LayoutTests/ChangeLog:10
> + * http/tests/media/resources/hls/test-video-duration-accessibility.php: Added.</span >
This file isn't accessibility-specific, how about something like "generate-vod.php"?
<span class="quote">> LayoutTests/http/tests/media/hls/video-duration-accessibility.html:36
> + // We are not getting the exact same elapsed duration for hour cases,
> + // so let's special case this.</span >
What does this mean, is it something we need to fix?
<span class="quote">> LayoutTests/http/tests/media/hls/video-duration-accessibility.html:42
> + if (elapsedTimer.description.indexOf("Hour") !== -1) {
> + testExpected("elapsedTimer.description.indexOf('1 Hour') !== -1 || elapsedTimer.description.indexOf('2 Hours') !== -1", true);
> + } else {
> + consoleWrite("elapsedTimer.description: " + elapsedTimer.description);
> + }
> + </span >
Nit: WebKit style is to not use braces for single line if statements.
<span class="quote">> LayoutTests/http/tests/media/hls/video-duration-accessibility.html:47
> + if (seekCount == seekTimes.length) {
> + endTest();
> + } else {
> + video.fastSeek(seekTimes[seekCount]);
> + }</span >
Ditto.
<span class="quote">> LayoutTests/http/tests/media/resources/hls/test-video-duration-accessibility.php:10
> +// header("Content-Length: " . filesize(__FILE__));</span >
Nit: this isn't necessary.
<span class="quote">> LayoutTests/http/tests/media/resources/hls/test-video-duration-accessibility.php:13
> +$chunkDuration = 6.0272;
> +$chunkCount = 1300;</span >
I would prefer that the duration of the file come from an optional parameter so we can use this for other tests in the future. Something like (untested):
$chunkCount = 1300;
if (array_key_exists("duration", $_GET))
$chunkCount = $_GET["duration"] / $chunkDuration;</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>