[Webkit-unassigned] [Bug 158083] LLInt should support other types of prototype GetById caching.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=158083

--- Comment #113 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 285082
  --> https://bugs.webkit.org/attachment.cgi?id=285082
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285082&action=review

> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:679
> +                if (slot.isValue()) {

I don't think you need this check. This block is dominated by a check that the slot is a value.

> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:1474
> +        if ARM or ARMv7 or ARMv7_TRADITIONAL or MIPS

I think you want. if (COMPILER_SUPPORTS(EABI) and ARM) or MIPS. Not all ARM devices use the EABI.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160805/261af964/attachment.html>