<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - LLInt should support other types of prototype GetById caching."
href="https://bugs.webkit.org/show_bug.cgi?id=158083#c113">Comment # 113</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - LLInt should support other types of prototype GetById caching."
href="https://bugs.webkit.org/show_bug.cgi?id=158083">bug 158083</a>
from <span class="vcard"><a class="email" href="mailto:keith_miller@apple.com" title="Keith Miller <keith_miller@apple.com>"> <span class="fn">Keith Miller</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=285082&action=diff" name="attach_285082" title="Patch">attachment 285082</a> <a href="attachment.cgi?id=285082&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=285082&action=review">https://bugs.webkit.org/attachment.cgi?id=285082&action=review</a>
<span class="quote">> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:679
> + if (slot.isValue()) {</span >
I don't think you need this check. This block is dominated by a check that the slot is a value.
<span class="quote">> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:1474
> + if ARM or ARMv7 or ARMv7_TRADITIONAL or MIPS</span >
I think you want. if (COMPILER_SUPPORTS(EABI) and ARM) or MIPS. Not all ARM devices use the EABI.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>