[Webkit-unassigned] [Bug 160529] Remove old Qt database tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=160529

Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #285287|review?                     |review-
              Flags|                            |

--- Comment #5 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 285287
  --> https://bugs.webkit.org/attachment.cgi?id=285287
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285287&action=review

This patch does not make sense. Both the description in this bug (comment #0) and the description in the ChangeLog do not explain how the functions testRunner.{closeIdleLocalStorageDatabases, setStorageDatabaseIdleInterval}(), used to test functionality of local storage, are related to "QT" (sic).

> LayoutTests/ChangeLog:11
> +        Removed tests and references to a number of old tests designed
> +        to support QT.  The two TestRunner functions involved were:
> +             testRunner.closeIdleLocalStorageDatabases
> +             testRunner.setStorageDatabaseIdleInterval

I think when you write "QT" that you are referring to the Qt WebKit port, but I'm unclear these local storage functions relate to that port. As Alex remarked in test LayoutTests/storage/resources/storage-close-idle-localstorage-databases-immediately.html, the function testRunner.closeIdleLocalStorageDatabases() was added in <https://trac.webkit.org/changeset/136323> and only implemented for Mac. The function testRunner.setStorageDatabaseIdleInterval() was added in <https://trac.webkit.org/changeset/122174> and only implemented for Mac.

>>> LayoutTests/platform/mac-wk2/TestExpectations:-273
>>> -webkit.org/b/147075 http/tests/cache/disk-cache/disk-cache-disable.html [ Pass Failure Timeout ]
>> 
>> This seems unrelated.
> 
> This is in connection to r42684 which uncovered the failing tests noted here.  This test is marked as failing but in fact, passes on everything but GTK

Alex is referring to the fact that the change to this line is unrelated to the purpose of this bug to "remove old [QT] database tests" because the test http/tests/cache/disk-cache/disk-cache-disable.html is a disk cache test. That is, it is not a database test. The WebKit OpenSource Project prefers the approach of one fix per bug/patch. So, we should keep this patch focused on removing the Qt database tests and create a new bug/patch to remove the test http/tests/cache/disk-cache/disk-cache-disable.html.

On another note, I'm unclear how r42684 <http://trac.webkit.org/changeset/42684>, which is build fix that was made 7 years ago, relates to this test or any of the other tests removed in this patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160804/389e0b48/attachment.html>